Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The server.addr configuration in tiflash-learner.toml does not take effect #3538

Closed
hehechen opened this issue Nov 23, 2021 · 0 comments
Closed

The server.addr configuration in tiflash-learner.toml does not take effect #3538

hehechen opened this issue Nov 23, 2021 · 0 comments
Assignees
@hehechen
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@hehechen
Copy link
Contributor

hehechen commented Nov 23, 2021 •
edited
Loading

After the PR #3414 merged, The server.addr configuration in tiflash-learner.toml does not take effect. Because in #3414, if the user does not set the configuration flash.proxy.addr, TiFlash will use 127.0.0.1:20170 as the addr startup parameter of TiFlash Proxy.
We need to make the configuration of server.addr in tiflash-learner.toml take effect, and keep the default values of addr and status_addr consistent with tiup and the doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hehechen hehechen

Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lilinghai @hehechen