Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test of scalar expressions #1690

Open
25 of 87 tasks
leiysky opened this issue Mar 30, 2021 · 1 comment
Open
25 of 87 tasks

Enhance test of scalar expressions #1690

leiysky opened this issue Mar 30, 2021 · 1 comment
Assignees
Labels
component/expression type/enhancement The issue or PR belongs to an enhancement.

Comments

@leiysky
Copy link
Contributor

leiysky commented Mar 30, 2021

So far, we only have integration test(e.g. fullstack-test, mock-test, sqllogic with randgen cases) and poor unit test to ensure correctness of scalar expressions, which has low test coverage and cannot help us find bugs automatically.

IMO, test of TiFlash scalar expressions should cover:

  • for all the input argument, should tests 3 types of input column: column_vector, column_constant, column_null
  • for all the input argument, the value of intput should include min_value, max_value, empty_value and other corner cases.

Tracking lists of tests:

@leiysky leiysky added type/enhancement The issue or PR belongs to an enhancement. component/expression labels Mar 30, 2021
@leiysky leiysky self-assigned this Mar 30, 2021
@fuzhe1989 fuzhe1989 assigned fuzhe1989 and windtalker and unassigned fuzhe1989 Nov 15, 2021
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Dec 14, 2021

There is a known out-of-bound bug in json_length: #2705. /cc @windtalker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants