From 9929b1952d9435f14004b3f7a1af1401a817e41e Mon Sep 17 00:00:00 2001 From: Calvin Neo Date: Mon, 3 Jun 2024 17:55:25 +0800 Subject: [PATCH] *: Use prefix tiflash_ for thread-wise memory alloc info (#9114) close pingcap/tiflash#8835 Signed-off-by: CalvinNeo --- dbms/src/Common/TiFlashMetrics.h | 2 +- metrics/grafana/tiflash_summary.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dbms/src/Common/TiFlashMetrics.h b/dbms/src/Common/TiFlashMetrics.h index 5552fc22617..996c1b0a785 100644 --- a/dbms/src/Common/TiFlashMetrics.h +++ b/dbms/src/Common/TiFlashMetrics.h @@ -1139,7 +1139,7 @@ class TiFlashMetrics static constexpr auto current_metrics_prefix = "tiflash_system_current_metric_"; static constexpr auto async_metrics_prefix = "tiflash_system_asynchronous_metric_"; static constexpr auto raft_proxy_thread_memory_usage = "tiflash_raft_proxy_thread_memory_usage"; - static constexpr auto storages_thread_memory_usage = "storages_thread_memory_usage"; + static constexpr auto storages_thread_memory_usage = "tiflash_storages_thread_memory_usage"; std::shared_ptr registry = std::make_shared(); // Here we add a ProcessCollector to collect cpu/rss/vsize/start_time information. diff --git a/metrics/grafana/tiflash_summary.json b/metrics/grafana/tiflash_summary.json index 460701f0f30..44c664a11b0 100644 --- a/metrics/grafana/tiflash_summary.json +++ b/metrics/grafana/tiflash_summary.json @@ -9053,7 +9053,7 @@ "targets": [ { "exemplar": true, - "expr": "storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"alloc_.*\"}", + "expr": "tiflash_storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"alloc_.*\"}", "format": "time_series", "interval": "", "intervalFactor": 2, @@ -9062,7 +9062,7 @@ }, { "exemplar": true, - "expr": "-storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"dealloc_.*\"}", + "expr": "-tiflash_storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"dealloc_.*\"}", "format": "time_series", "hide": false, "interval": "",