Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use release-2.1 parser #9886

Merged
merged 1 commit into from
Mar 25, 2019
Merged

*: use release-2.1 parser #9886

merged 1 commit into from
Mar 25, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 25, 2019

fix wrong merge of #9880 and use pingcap/parser#257 's parser

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp jackysp merged commit e549680 into pingcap:release-2.1 Mar 25, 2019
@lysu lysu deleted the dev-update-2.1-parser branch March 25, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants