Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add binlog socket config for compatible with kafka version pump #8747

Merged
merged 5 commits into from
Dec 19, 2018
Merged

add binlog socket config for compatible with kafka version pump #8747

merged 5 commits into from
Dec 19, 2018

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Dec 19, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

add binlog socket config for compatible with kafka version pump
already merge to master, cherry pick to release 2.1
pr: #8732

What is changed and how it works?

git cherry-pick
and then resolve some conflict

Check List

Tests

  • Integration test

Related changes

  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

This change is Reviewable

jackysp
jackysp reviewed Dec 19, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IANTHEREAL
IANTHEREAL previously approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 19, 2018
@WangXiangUSTC
Copy link
Contributor Author

/rebuild

zimulala
zimulala reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to config_test.go?

@zimulala
Copy link
Contributor

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/rebuild

@WangXiangUSTC
Copy link
Contributor Author

add test done @zimulala

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

zimulala
zimulala reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 79180dc into pingcap:release-2.1 Dec 19, 2018
@WangXiangUSTC WangXiangUSTC deleted the xiang/cherry-pick branch December 25, 2018 08:34
@Xuanwo Xuanwo mentioned this pull request Dec 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zimulala zimulala zimulala left review comments

@july2993 july2993 july2993 approved these changes

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

Assignees
No one assigned
Labels
component/binlog status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @zimulala @july2993 @jackysp @IANTHEREAL