Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: update parser to make TiDB treat charset and collate case insensitive (#8577) #8611

Merged
merged 5 commits into from
Dec 12, 2018
Merged

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 7, 2018

Cherry-pick from #8577

Merge pingcap/parser#70 first. I will update the go.mod after the parser pr is merged.


This change is Reviewable

@jackysp
Copy link
Member

jackysp commented Dec 7, 2018

pingcap/parser#70 is merged @winkyao

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor Author

winkyao commented Dec 8, 2018

go.mod is updated.

@winkyao
Copy link
Contributor Author

winkyao commented Dec 9, 2018

@tiancaiamao PTAL

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. component/DDL-need-LGT3 labels Dec 10, 2018
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 10, 2018

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

2 similar comments
@zhouqiang-cl
Copy link
Contributor

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 11, 2018

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit f3dc5ee into pingcap:release-2.1 Dec 12, 2018
@winkyao winkyao deleted the cherry-pick-2,1 branch December 12, 2018 02:33
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants