Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix incorrect date arithmitical with negative interval (#8523) #8574

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

nanne007
Copy link
Contributor

@nanne007 nanne007 commented Dec 4, 2018

What problem does this PR solve?

cherry pick #8523 to release-2.1

What is changed and how it works?

No conflict happened during cherry-picking.

Check List

Tests

  • Unit test

This change is Reviewable

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@nanne007 nanne007 changed the title expression: fix incorrect date arithmitical with negative interval expression: fix incorrect date arithmitical with negative interval (#8523) Dec 4, 2018
@zz-jason
Copy link
Member

zz-jason commented Dec 4, 2018

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the contribution This PR is from a community contributor. label Dec 4, 2018
@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 4, 2018
@eurekaka
Copy link
Contributor

eurekaka commented Dec 4, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@zz-jason
Copy link
Member

zz-jason commented Dec 4, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit b4b9f21 into pingcap:release-2.1 Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants