-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Make use of the upperBound of ticlient's kv_scan interface to ensure no overbound scan will happen (#8081) #8310
Merged
winkyao
merged 6 commits into
pingcap:release-2.0
from
MyonKeminta:misono/2.0-end-key-limit
Nov 19, 2018
Merged
*: Make use of the upperBound of ticlient's kv_scan interface to ensure no overbound scan will happen (#8081) #8310
winkyao
merged 6 commits into
pingcap:release-2.0
from
MyonKeminta:misono/2.0-end-key-limit
Nov 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
…re no overbound scan will happen (pingcap#8081) Signed-off-by: MyonKeminta <[email protected]>
/run-all-tests pd=release-2.0 tikv=pr/3780 tidb-test=release-2.0 |
Signed-off-by: MyonKeminta <[email protected]>
/run-unit-test |
zz-jason
changed the title
[DNM] [release-2.0] cherry-pick: *: Make use of the upperBound of ticlient's kv_scan interface to ensure no overbound scan will happen (#8081)
*: Make use of the upperBound of ticlient's kv_scan interface to ensure no overbound scan will happen (#8081)
Nov 14, 2018
…nd-key-limit Signed-off-by: MyonKeminta <[email protected]>
/run-all-tests pd=release-2.0 tikv=release-2.0 tidb-test=release-2.0 |
LGTM |
@winkyao PTAL |
winkyao
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR cherry-picks #8081 (09c6bff) to release-2.0 branch to fix the bug that scanning out-of-range may cause TiKV
This PR requires merging #8309 first.
What is changed and how it works?
This PR cherry-picks #8081 (09c6bff) to release-2.0 branch.
Check List
Tests
Manually confirm that TiKV won't panic while executing
add index
oradmin check table
.t1
andt2
, insert some data in to them (values' length is large enough)t1
andt2
's table_id (0x21 and 0x23)t2
from default_cf by using RawKv APIalter table t1 add index i1(id)
andadmin check table t1
in both current release-2.0 and this PR.Test result: In current release 2.0 branch TiKV will panic, while in this PR nothing strange happens.
Code changes
Side effects
Related changes
This change is