*: avoid using columnEvaluator for the Projectin build by buildProjtion4Union #8142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
winoros
reviewed
Nov 1, 2018
Co-Authored-By: XuHuaiyu <[email protected]>
zz-jason
added
status/LGT2
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 5, 2018
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 5, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 5, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8141
What is changed and how it works?
As the title says. This is a workaround to fix the issue.
The issue happens because that one of the result Chunk actually has 1 column, which the other has 2 columns.
UnionExec is executed parallelly, and the result Chunks of the two children will be re-used together.
When the child which need a Chunk with 2 columns fetches a Chunk with 1 column, it will cause unexcepted behavior.
After we support column pool(#7971), this situation can be avoided.
Check List
Tests
Code changes
Side effects
Related changes
release-2.0 release-2.1