Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: limit the length of sample values (#7931) #7982

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 22, 2018

What problem does this PR solve?

Cherry-pick #7931

What is changed and how it works?

Cherry-pick #7931

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@iamxy
Copy link
Member

iamxy commented Oct 22, 2018

/run-all-tests

3 similar comments
@iamxy
Copy link
Member

iamxy commented Oct 22, 2018

/run-all-tests

@iamxy
Copy link
Member

iamxy commented Oct 22, 2018

/run-all-tests

@iamxy
Copy link
Member

iamxy commented Oct 22, 2018

/run-all-tests

@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

@lamxTyler should we also cherry pick it to release-2.0?

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 23, 2018
@zz-jason
Copy link
Member

/run-integration-common-test
/run-integration-compatibility-test
/run-integration-ddl-test

@zz-jason zz-jason added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Oct 23, 2018
@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 23, 2018

@zz-jason Yes.

@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 23, 2018

/run-integration-common-test
/run-integration-compatibility-test
/run-integration-ddl-test

@zz-jason
Copy link
Member

/run-integration-common-test tikv=release-2.1 pd=release-2.1
/run-integration-compatibility-test tikv=release-2.1 pd=release-2.1
/run-integration-ddl-test tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

/run-integration-common-test tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit c2c7d3d into pingcap:release-2.1 Oct 23, 2018
@alivxxx alivxxx deleted the sample-length branch October 23, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants