-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix missing microsecond for timestamp #7418
Conversation
@imtbkcat Please add some UT |
PTAL @zz-jason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fix #7334 to make JDBC test happy.
What is changed and how it works?
Microsecond missed in add function because
date.Fsp
become 0 when we use now() and don't setdate.Fsp
to 6. I add some code to setdate.Fsp = 6
if added with microsecond.Before:
After:
Check List
Tests
Code changes
Side effects
no
Related changes