Add advertise-address to config
#7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
force-pushed
the
add_advertise-address_to_config
branch
from
89eab91 to
726ebe2
Compare
|
Please add proper labels. |
|
This PR definitely affect documentation. |
|
This is still "No":
|
coocood
reviewed
Jul 17, 2018
config/config.toml.example
Outdated
| @@ -3,6 +3,9 @@ | |||
| # TiDB server host. | |||
| host = "0.0.0.0" | |||
|
|
|||
| # tidb server advertise IP. | |||
| advertise-ip = "" | |||
|
I think this PR needs to be added to the release notes. |
shenli
reviewed
Jul 18, 2018
| @@ -3,6 +3,9 @@ | |||
| # TiDB server host. | |||
| host = "0.0.0.0" | |||
|
|
|||
| # tidb server advertise IP. | |||
There was a problem hiding this comment.
Will the address contain port? Or only IP?
There was a problem hiding this comment.
Can we obtain the IP from system information?
|
LGTM |
shenli
approved these changes
Jul 18, 2018
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
advertise-addressconfiguration to config.advertise-addressis the current TiDB server IP. We need put some information such as IP to PD.This is for issue#6961hostof the config directly? Because thehostMaybe "0.0.0.0"What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Yes.
Does this PR affect tidb-ansible update? (mandatory)
Yes.
Does this PR need to be added to the release notes? (mandatory)
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)