Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version of GO should be 1.10 or above. #6969

Merged
merged 1 commit into from
Jul 3, 2018
Merged

The version of GO should be 1.10 or above. #6969

merged 1 commit into from
Jul 3, 2018

Conversation

zbdba
Copy link
Contributor

@zbdba zbdba commented Jul 3, 2018

What have you changed? (mandatory)

The version of GO should be 1.10 or above,because 1.9 can't support math.Round

What are the type of the changes (mandatory)?

Bug fix

How has this PR been tested (mandatory)?

Use GO 1.9.4 version:

[root@zbdba tidb]# make server
make parser
make[1]: Entering directory /data1/source_code/src/github.com/pingcap/tidb' CGO_ENABLED=0 go build -o bin/goyacc parser/goyacc/main.go bin/goyacc -o /dev/null parser/parser.y Parse table entries: 708693 of 1797400, x 16 bits == 1417386 bytes bin/goyacc -o parser/parser.go parser/parser.y 2>&1 | egrep "(shift|reduce)/reduce" | awk '{print} END {if (NR > 0) {print "Find conflict in parser.y. Please check y.output for more information."; exit 1;}}' rm -f y.output make[1]: Leaving directory /data1/source_code/src/github.com/pingcap/tidb'
CGO_ENABLED=0 go build -ldflags '-X "github.com/pingcap/tidb/mysql.TiDBReleaseVersion=v2.1.0-beta-7-gf6ee36e" -X "github.com/pingcap/tidb/util/printer.TiDBBuildTS=2018-07-03 06:49:15" -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=f6ee36e08c3a11b9c93135f79e4ed984bee9564c" -X "github.com/pingcap/tidb/util/printer.TiDBGitBranch=master" -X "github.com/pingcap/tidb/util/printer.GoVersion=go version go1.9.4 linux/amd64"' -o bin/tidb-server tidb-server/main.go
github.com/pingcap/tidb/statistics
statistics/histogram.go:124:10: undefined: math.Round
make: *** [server] Error 2

use GO 1.10.3 version:

make success

@sre-bot
Copy link
Contributor

sre-bot commented Jul 3, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shenli shenli added component/docs contribution This PR is from a community contributor. labels Jul 3, 2018
@shenli
Copy link
Member

shenli commented Jul 3, 2018

LGTM

@shenli
Copy link
Member

shenli commented Jul 3, 2018

@zbdba Thanks!

@shenli shenli added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2018
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 3, 2018
@ngaut ngaut merged commit 1f6e12c into pingcap:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants