plan: resolve indices for apply schema #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the apply schema is not resolved, the handle will be lost, then update will update the row with 0 handle.
|
/run-all-tests |
zimulala
reviewed
May 11, 2018
executor/write_test.go
Outdated
| tk.MustExec("insert detail values ('abc', '123', 2)") | ||
| tk.MustExec(` | ||
| UPDATE msg SET msg.status = (SELECT detail.status FROM detail WHERE detail.start = '123' AND msg.id = detail.id) | ||
| WHERE EXISTS (SELECT 1 FROM detail d WHERE d.start = '123' AND msg.id = d.id)`) |
There was a problem hiding this comment.
Could we remove line 1607? I think it makes the test easier
ngaut
approved these changes
May 11, 2018
|
/run-all-tests |
|
/run-unit-test |
coocood
added a commit
to coocood/tidb
that referenced
this pull request
May 11, 2018
tiancaiamao
pushed a commit
that referenced
this pull request
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the apply schema is not resolved, the handle will be lost, then update will update the row with 0 handle.