statistics: uniform the calculation of pseudo stats. #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tidb-test=pr/517 |
alivxxx
reviewed
May 7, 2018
plan/stats.go
Outdated
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| // statsInfo stores the basic information of statistics for the plan's output. It is used for cost estimation. | ||
| type statsInfo struct { | ||
| count float64 | ||
| cardinality []float64 | ||
| colHist []statistics.Column |
There was a problem hiding this comment.
Oh it's something should be done in next pr.
|
/run-all-tests tidb-test=pr/517 |
|
CI failed @winoros . |
|
/run-common-test tidb-test=pr/517 |
|
/run-unit-test |
|
/run-all-tests tidb-test=pr/517 |
zimulala
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
Selectivitynot a method ofstatistics.Table. It's inner logic should not rely onTable.Pseudo.