session: upgrade mysql.db user column length to 32 #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep consistent with MySQL, so we won't meet this error: tidb(127.0.0.1)> grant all privileges on test.* to 'abcddfjakldfjaldddds'@'%' identified by ''; ERROR 1406 (22001): Data too long for column 'User' at row 1
|
LGTM |
|
/run-all-tests |
|
/run-all-tests |
|
/run-circleci |
coocood
previously approved these changes
Apr 3, 2018
zimulala
previously requested changes
Apr 3, 2018
session/session_test.go
Outdated
| func (s *testSessionSuite) TestDBUserNameLength(c *C) { | ||
| tk := testkit.NewTestKitWithInit(c, s.store) | ||
| tk.MustExec("create table if not exists t (a int)") | ||
| // Test user name lengh can be longer than 16. |
coocood
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep consistent with MySQL, so we won't meet this error:
@XuHuaiyu @coocood