expression: remove unnecessary warnings for AND/OR expressions | tidb-test=pr/2409

[gengliqi]

What problem does this PR solve?

Issue Number: close #56481

Problem Summary:
This PR is intended to fix the bug introduced by the fix PRs of #17725.
The unnecessary warnings appear when evaluating the first argument generates some warnings and evaluating the second argument generates errors or warnings.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @gengliqi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3802%. Comparing base (df821b9) to head (850c96e).
Report is 8 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56482        +/-   ##
================================================
+ Coverage   73.2357%   75.3802%   +2.1444%     
================================================
  Files          1626       1626                
  Lines        448692     449456       +764     
================================================
+ Hits         328603     338801     +10198     
+ Misses        99977      90110      -9867     
- Partials      20112      20545       +433     

Flag	Coverage Δ
integration	48.8434% <100.0000%> (?)
unit	72.5006% <100.0000%> (+0.0604%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	52.8980% <ø> (+7.4266%)	⬆️

[gengliqi]

/test mysql-test

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/retest

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

lgtm

[yibin87]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker]
• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-09 01:29:26.798095798 +0000 UTC m=+1009522.218308802: ☑️ agreed by windtalker.
• 2024-10-09 02:32:18.604618184 +0000 UTC m=+1013294.024831235: ☑️ agreed by yibin87.

[purelind]

Please wait for this PR #51126 to be merged first.

[gengliqi]

/test check-dev2

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/test mysql-test

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/test mysql-test

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/retest

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.