Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the case that fails to split a table #5496

Merged
merged 4 commits into from
Dec 26, 2017

Conversation

zimulala
Copy link
Contributor

If we fail to split a table, but the table is created, we will get an error as follows:

mysql> create database sbtest;
Query OK, 0 rows affected (0.09 sec)
mysql> use sbtest;
Database changed
mysql> CREATE TABLE `shtable` (
    ->   `id` int(11) NOT NULL AUTO_INCREMENT,
    ->    PRIMARY KEY (`id`)
    ->  );
ERROR 1050 (42S01): Table 'shtable' already exists

@zimulala
Copy link
Contributor Author

/run-all-tests

@zimulala
Copy link
Contributor Author

PTAL @disksing @coocood @shenli

@coocood
Copy link
Member

coocood commented Dec 26, 2017

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 26, 2017
@shenli
Copy link
Member

shenli commented Dec 26, 2017

LGTM

@shenli shenli added all-tests-passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 26, 2017
@winoros winoros merged commit c003acf into pingcap:master Dec 26, 2017
@zimulala zimulala deleted the split-table branch January 2, 2018 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants