Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: make the transaction from initStatsCtx blocking gc (#53602) #53633

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53602

What problem does this PR solve?

Issue Number: close #53592

Problem Summary:

The initStatsCtx is not get from internal session pool, so it's not tracked by min start ts service, thus gc lifetime can overtake it easily.

What changed and how does it work?

Insert it into tracked session table and it will block gc.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

I reproduce the test mentioned in issue, the stats are loaded successfully after 30min.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix a bug that tidb will report gc lifetime too short when tidb bootstrap with slow loading statistics

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 28, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels May 28, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 28, 2024
@cfzjywxk
Copy link
Contributor

@you06 Please resolve the conflicts.

Signed-off-by: you06 <[email protected]>
@you06
Copy link
Contributor

you06 commented May 28, 2024

/retest

@you06
Copy link
Contributor

you06 commented May 28, 2024

@cfzjywxk conflict resolved, PTAL again

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
Copy link

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 10:23:46.166018013 +0000 UTC m=+2771979.923153578: ☑️ agreed by hawkingrei.
  • 2024-05-28 13:41:33.385282717 +0000 UTC m=+2783847.142418290: ☑️ agreed by cfzjywxk.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@5a66534). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53633   +/-   ##
================================================
  Coverage               ?   72.0293%           
================================================
  Files                  ?       1411           
  Lines                  ?     410619           
  Branches               ?          0           
================================================
  Hits                   ?     295766           
  Misses                 ?      94979           
  Partials               ?      19874           
Flag Coverage Δ
unit 72.0293% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4681% <0.0000%> (?)

@cfzjywxk
Copy link
Contributor

/merge

Copy link

ti-chi-bot bot commented May 28, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@you06
Copy link
Contributor

you06 commented May 28, 2024

@lance6716 PTAL, handsome domain owner.

Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit 318ffba into pingcap:release-7.5 May 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants