Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove useless binding code and add more test cases #50098

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 4, 2024

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: remove useless binding code

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2024
Copy link

tiprow bot commented Jan 4, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 changed the title planner: remove useless binding code planner: remove useless binding code and add more test cases Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #50098 (2121043) into master (617eb0a) will increase coverage by 2.6185%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50098        +/-   ##
================================================
+ Coverage   79.3332%   81.9518%   +2.6185%     
================================================
  Files          2442       2444         +2     
  Lines        673096     673315       +219     
================================================
+ Hits         533989     551794     +17805     
+ Misses       117778     100786     -16992     
+ Partials      21329      20735       -594     
Flag Coverage Δ
integration 48.6820% <100.0000%> (?)
unit 79.2890% <100.0000%> (-0.0442%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (ø)
parser ∅ <ø> (∅)
br 71.8754% <ø> (+3.3538%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 4, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-04 15:57:54.916373541 +0000 UTC m=+2358965.953600462: ☑️ agreed by hawkingrei.
  • 2024-01-05 00:55:54.782167757 +0000 UTC m=+2391245.819394670: ☑️ agreed by fzzf678.

@ti-chi-bot ti-chi-bot bot merged commit d11a559 into pingcap:master Jan 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants