Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests, executor, br: fix time_zone related bugs in UT #49588

Merged
merged 10 commits into from
Dec 20, 2023
Merged

tests, executor, br: fix time_zone related bugs in UT #49588

merged 10 commits into from
Dec 20, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #49493

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@tiprow tiprow
Copy link

tiprow bot commented Dec 19, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Merging #49588 (6392658) into master (0719329) will increase coverage by 0.5216%.
Report is 21 commits behind head on master.
The diff coverage is 20.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49588        +/-   ##
================================================
+ Coverage   71.0033%   71.5250%   +0.5216%     
================================================
  Files          1368       1421        +53     
  Lines        399350     418497     +19147     
================================================
+ Hits         283552     299330     +15778     
- Misses        96007     100234      +4227     
+ Partials      19791      18933       -858
Flag Coverage Δ
integration 43.6292% <20.0000%> (?)
unit 71.0029% <ø> (-0.0005%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2778% <ø> (-5.6152%) ⬇️

@Defined2014
Copy link
Contributor Author

/test check-dev2

@tiprow tiprow
Copy link

tiprow bot commented Dec 19, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/test check-dev2

@tiprow tiprow
Copy link

tiprow bot commented Dec 20, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title tests, executor: fix time_zone related bugs tests, executor, br: fix time_zone related bugs Dec 20, 2023
zimulala
zimulala reviewed Dec 20, 2023
View reviewed changes
pkg/expression/integration_test/integration_test.go
@@ -63,7 +63,7 @@ func TestGetLock(t *testing.T) {
// Increase pessimistic txn max retry count to make test more stable.
originCfg := config.GetGlobalConfig()
newCfg := *originCfg
newCfg.PessimisticTxn.MaxRetryCount = 2048
newCfg.PessimisticTxn.MaxRetryCount = 10240
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Increase pessimistic txn max retry count to make test more stable., but sometimes 2048 is not big enough.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 20, 2023
@Defined2014
Copy link
Contributor Author

/test check-dev2

@tiprow tiprow
Copy link

tiprow bot commented Dec 20, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 02:22:44.487037913 +0000 UTC m=+1014055.524264825: ☑️ agreed by zimulala.
  • 2023-12-20 06:31:28.132537284 +0000 UTC m=+1028979.169764193: ☑️ agreed by XuHuaiyu.

@Defined2014 Defined2014 added the ok-to-test Indicates a PR is ready to be tested. label Dec 20, 2023
@Defined2014 Defined2014 changed the title tests, executor, br: fix time_zone related bugs tests, executor, br: fix time_zone related bugs in UT Dec 20, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, hawkingrei, XuHuaiyu, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit a09facc into pingcap:master Dec 20, 2023
30 checks passed
@Defined2014 Defined2014 deleted the fix-time-zone-1 branch December 20, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zimulala zimulala zimulala approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests can't pass when time_zone not equal to Asia/Shanghai
5 participants
@Defined2014 @hawkingrei @zimulala @XuHuaiyu @BornChanger