Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distribute framework: add planner #46395
distribute framework: add planner #46395
Changes from all commits
40ef59f
e200895
69d8ed6
70cf160
11b5de1
c14a836
2564090
d530616
c90e10c
bbe2c8e
3d6a59e
93ec35d
9778991
c64a464
bede27d
e51275b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hold task_table as member?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The planner in tidb runtime also fetch meta data from tikv. So I think it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using PreviousSubtaskMetas is to express that PreviousSubtaskMetas is the result of the previous step. If we use task_table, our planner will be coupled with the system table again, although adding a new interface would be more convenient. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more detailed comments to show the arch of the planner?
Check warning on line 70 in disttask/framework/planner/plan.go
Codecov / codecov/patch
disttask/framework/planner/plan.go#L69-L70
Check warning on line 24 in disttask/framework/planner/planner.go
Codecov / codecov/patch
disttask/framework/planner/planner.go#L23-L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No usage?
Check warning on line 32 in disttask/framework/planner/planner.go
Codecov / codecov/patch
disttask/framework/planner/planner.go#L31-L32
Check warning on line 37 in disttask/framework/planner/planner.go
Codecov / codecov/patch
disttask/framework/planner/planner.go#L36-L37