Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore: set config value to default when failed to get config from tikv (#36051) #40253

Merged
merged 6 commits into from
Jan 18, 2023
Merged

restore: set config value to default when failed to get config from tikv (#36051) #40253

merged 6 commits into from
Jan 18, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #36051

Signed-off-by: Yu Juncen [email protected]

What problem does this PR solve?

Issue Number: close #36053

Problem Summary:
If we failed to get region size config from TiKV, we abort the restore procedure, which may not be robust.

What is changed and how it works?

Use the default config if the region size cannot be fetched from TiKV.

Check List

Tests

(TBD)

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that may cause BR reject to restore unexpectedly.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Dec 30, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 30, 2022
Merged
2 tasks
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 30, 2022
@wuhuizuo
Copy link
Contributor

/retest mysql-test

@ti-chi-bot
Copy link
Member Author

@wuhuizuo: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/retest mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/test mysql-test

@3pointer
Copy link
Contributor

/rebuild

1 similar comment
@3pointer
Copy link
Contributor

/rebuild

@3pointer
Copy link
Contributor

/retest

@3pointer
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2023
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ef4a024

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@ti-chi-bot ti-chi-bot merged commit 9e3b12f into pingcap:release-6.1 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengou1 fengou1 fengou1 approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees

@YuJuncen YuJuncen

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-chi-bot @wuhuizuo @3pointer @Leavrth @fengou1 @VelocityLight @YuJuncen @Ivy-YinSu