-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: escape parameters for finish job sql (#40118) #40144
ttl: escape parameters for finish job sql (#40118) #40144
Conversation
Signed-off-by: YangKeao <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0e2db3f
|
This is an automated cherry-pick of #40118
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #40115
Problem Summary:
The summary could contain special characters (as it's a json containing error message, and the error message is unpredictable). We should pass it through the parameters.
What is changed and how it works?
Pass the summary through parameters, and it should be escaped automatically. This PR also append the SQL to the error information for debug.
Check List
Tests
Release note