executor: fix aggregating enum zero value gets different results from mysql #36208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
needs-cherry-pick-release-5.0
needs-cherry-pick-release-5.1
needs-cherry-pick-release-5.2
needs-cherry-pick-release-5.3
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/dec1b4d0e12a178b61b0751f880ff9d0748ad8c4 |
ywqzzy
force-pushed
the
fix_agg_enum_invalid_value
branch
from
4ca98de to
ab9efde
Compare
|
/run-mysql-test-test |
|
/run-mysql-test-test |
|
/run-mysql-test-test tidb-test=pr/1896 |
|
/cc @mengxin9014 |
|
changes in mysql-test: https://github.com/pingcap/tidb-test/pull/1896 |
wshwsh12
approved these changes
Jul 22, 2022
XuHuaiyu
approved these changes
Jul 22, 2022
ti-chi-bot
added
status/LGT2
|
/run-unit-test-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-5.0 in PR #36459 |
12 tasks
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.1 in PR #36460 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-5.2 in PR #36461 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-5.3 in PR #36462 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-5.4 in PR #36463 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-6.0 in PR #36465 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-6.1 in PR #36466 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2022
Signed-off-by: ti-srebot <[email protected]>
12 tasks
|
cherry pick to release-6.2 in PR #36467 |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jul 22, 2022
…ip-init * upstream/master: (125 commits) infoschema: fix PromQL for `tidb_distsql_copr_cache` (pingcap#36450) test: stabilize TestTopSQLCPUProfile (pingcap#36468) parser: add support of 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' transferring to AST (pingcap#36285) *: enable flaky test for all test (pingcap#36385) expression: fix return type of agg func `bit_or` when handling varbinary column (pingcap#36415) executor: fix aggregating enum zero value gets different results from mysql (pingcap#36208) server: skip check tiflash version (pingcap#36451) *: Minor update to SECURITY.md to improved clarity (pingcap#36346) table partition: add telemetry for partition table (pingcap#36204) ddl: invalid multiple MAXVALUE partitions (pingcap#36329) (pingcap#36345) planner: Fixed `Merge` hint in nested CTE (pingcap#36432) metric: impove concurrency ddl metrics (pingcap#36405) planner: add more test cases for leading outer join (pingcap#36409) ddl: only set concurrent variable if no error (pingcap#36437) ddl: fix update panic in the middle of multi-schema change (pingcap#36421) session: Mising OptimizeWithPlanAndThenWarmUp in prepare-execute path (pingcap#36347) executor,metrics: add a metric for observing execution phases (pingcap#35906) br: unified docker image align with tidb (pingcap#36016) ddl: skip to close nil sessPool (pingcap#36425) log-backup: remove the timezone from log-date (pingcap#36369) ...
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jul 22, 2022
* upstream/master: (280 commits) infoschema: fix PromQL for `tidb_distsql_copr_cache` (pingcap#36450) test: stabilize TestTopSQLCPUProfile (pingcap#36468) parser: add support of 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' transferring to AST (pingcap#36285) *: enable flaky test for all test (pingcap#36385) expression: fix return type of agg func `bit_or` when handling varbinary column (pingcap#36415) executor: fix aggregating enum zero value gets different results from mysql (pingcap#36208) server: skip check tiflash version (pingcap#36451) *: Minor update to SECURITY.md to improved clarity (pingcap#36346) table partition: add telemetry for partition table (pingcap#36204) ddl: invalid multiple MAXVALUE partitions (pingcap#36329) (pingcap#36345) planner: Fixed `Merge` hint in nested CTE (pingcap#36432) metric: impove concurrency ddl metrics (pingcap#36405) planner: add more test cases for leading outer join (pingcap#36409) ddl: only set concurrent variable if no error (pingcap#36437) ddl: fix update panic in the middle of multi-schema change (pingcap#36421) session: Mising OptimizeWithPlanAndThenWarmUp in prepare-execute path (pingcap#36347) executor,metrics: add a metric for observing execution phases (pingcap#35906) br: unified docker image align with tidb (pingcap#36016) ddl: skip to close nil sessPool (pingcap#36425) log-backup: remove the timezone from log-date (pingcap#36369) ...
joycse06
added a commit
to joycse06/tidb
that referenced
this pull request
Jul 23, 2022
…rimary-key * upstream/master: (104 commits) br: fix compatibility issue with concurrent ddl (pingcap#36474) infoschema: fix PromQL for `tidb_distsql_copr_cache` (pingcap#36450) test: stabilize TestTopSQLCPUProfile (pingcap#36468) parser: add support of 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' transferring to AST (pingcap#36285) *: enable flaky test for all test (pingcap#36385) expression: fix return type of agg func `bit_or` when handling varbinary column (pingcap#36415) executor: fix aggregating enum zero value gets different results from mysql (pingcap#36208) server: skip check tiflash version (pingcap#36451) *: Minor update to SECURITY.md to improved clarity (pingcap#36346) table partition: add telemetry for partition table (pingcap#36204) ddl: invalid multiple MAXVALUE partitions (pingcap#36329) (pingcap#36345) planner: Fixed `Merge` hint in nested CTE (pingcap#36432) metric: impove concurrency ddl metrics (pingcap#36405) planner: add more test cases for leading outer join (pingcap#36409) ddl: only set concurrent variable if no error (pingcap#36437) ddl: fix update panic in the middle of multi-schema change (pingcap#36421) session: Mising OptimizeWithPlanAndThenWarmUp in prepare-execute path (pingcap#36347) executor,metrics: add a metric for observing execution phases (pingcap#35906) br: unified docker image align with tidb (pingcap#36016) ddl: skip to close nil sessPool (pingcap#36425) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #26885
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.