codec: simplify json codec. #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
hhkbp2
reviewed
Jun 23, 2017
util/types/json/serdes.go
Outdated
| return | ||
| } | ||
| } | ||
| err = errors.New("Invalid JSON bytes") |
There was a problem hiding this comment.
Is it better to return different error message for 1. len(b) == 0, 2. b[0] is invalid ?
XuHuaiyu
reviewed
Jun 23, 2017
util/types/json/json_test.go
Outdated
| @@ -54,15 +54,16 @@ func (s *testJSONSuite) TestSerializeAndDeserialize(c *C) { | |||
| j2 := mustParseFromString(`[{"a": 1, "b": true}, 3, 3.5, "hello, world", null, true]`) | |||
|
|
|||
| var testcses = []struct { | |||
util/types/json/serdes.go
Outdated
| // PeekBytesAsJSON trys to peek some bytes from b, until | ||
| // we can deserialize a JSON from those bytes. | ||
| func PeekBytesAsJSON(b []byte) (n int, err error) { | ||
| if len(b) > 0 { |
There was a problem hiding this comment.
use len(b) <= 0 better?
thus avoiding the indentation
| @@ -93,6 +93,43 @@ import ( | |||
| // lengths up to 16383, and so on... | |||
| */ | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
add comments for these constants.
There was a problem hiding this comment.
The constant 4 is used somewhere else in this file, we could use a const variable for all of them.
util/types/json/serdes.go
Outdated
| // we can deserialize a JSON from those bytes. | ||
| func PeekBytesAsJSON(b []byte) (n int, err error) { | ||
| if len(b) > 0 { | ||
| switch c := b[0]; c { |
There was a problem hiding this comment.
Is TypeCode(b[0]) available?
If so, may be more readable.
|
Rest LGTM |
|
LGTM |
XuHuaiyu
approved these changes
Jun 23, 2017
XuHuaiyu
reviewed
Jun 23, 2017
util/types/json/serdes.go
Outdated
| @@ -97,34 +97,39 @@ const ( | |||
| typeCodeLen int = 1 | |||
There was a problem hiding this comment.
comment for these constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.