expression, executor: rewrite built-in func length using new expression evaluation architecture #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on evaluation architecture
hanfei1991
reviewed
Jun 21, 2017
expression/builtin_string.go
Outdated
| args, err := b.evalArgs(row) | ||
| func (b *builtinLengthSig) evalInt(row []types.Datum) (int64, bool, error) { | ||
| ctx, sc := b.ctx, b.ctx.GetSessionVars().StmtCtx | ||
| arg0, err := WrapWithCastAsString(b.args[0], ctx) |
There was a problem hiding this comment.
We should not add cast here.
shenli
reviewed
Jun 21, 2017
expression/builtin_string.go
Outdated
| @@ -132,32 +132,29 @@ type lengthFunctionClass struct { | |||
| } | |||
|
|
|||
| func (c *lengthFunctionClass) getFunction(args []Expression, ctx context.Context) (builtinFunc, error) { | |||
| sig := &builtinLengthSig{newBaseBuiltinFunc(args, ctx)} | |||
| tp := types.NewFieldType(mysql.TypeLonglong) | |||
| types.SetBinChsClnFlag(tp) | |||
XuHuaiyu
commented
Jun 21, 2017
expression/builtin_string.go
Outdated
| @@ -133,6 +133,7 @@ type lengthFunctionClass struct { | |||
|
|
|||
| func (c *lengthFunctionClass) getFunction(args []Expression, ctx context.Context) (builtinFunc, error) { | |||
| tp := types.NewFieldType(mysql.TypeLonglong) | |||
| tp.Flen = 10 | |||
There was a problem hiding this comment.
Conflicts: expression/builtin.go �:q!
|
PTAL @hanfei1991 |
|
PTAL @zimulala |
|
LGTM |
zimulala
reviewed
Jun 22, 2017
expression/builtin_string.go
Outdated
| return sig.setSelf(sig), errors.Trace(c.verifyArgs(args)) | ||
| } | ||
|
|
||
| type builtinLengthSig struct { | ||
| baseBuiltinFunc | ||
| baseIntBuiltinFunc | ||
| } | ||
|
|
||
| // eval evals a builtinLengthSig. |
zimulala
approved these changes
Jun 22, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite built-in func
lengthusing new expression evaluation architecturePTAL @hanfei1991 @shenli @hicqu