util/types:Handle out of range value when load data

[louishust]

When insert an overflow string like "1343545435346432587475"
to MySQL int type column, tidb will convert to max int64
instead of max int.

[louishust]

solve bug #3024

[XuHuaiyu]

you can add this test it in util/types/convert_test.go,
thus ToInt64WithTp , testDatumToInt64WithTargetType and testDatumToInt64WithTargetType can be removed.

[XuHuaiyu]

PTAL @zimulala

[shenli]

@louishust Should we distinguish between loading data and insert statement?

mysql> create table t (a int, b int not null);
Query OK, 0 rows affected (0.01 sec)

mysql> insert into t values (143, 1343545435346432587475);
ERROR 1264 (22003): Out of range value for column 'b' at row 1
mysql>

[louishust]

@shenli

mysql> set sql_mode="";
Query OK, 0 rows affected (0.01 sec)

mysql> insert into t1 values(1, "1343545435346432587475");
Query OK, 1 row affected, 1 warning (0.00 sec)

mysql> select * from t1;
+------+------------+
| a    | b          |
+------+------------+
|  143 | 2147483647 |
|    1 | 2147483647 |
+------+------------+
2 rows in set (0.00 sec)

I think the sql_mode is modified at load data command internal in MySQL.
I will check that in MySQL later.

[louishust]

@shenli

I checked MySQL code and find the following code in sql/sql_yacc.yy:

load:
.............
        if (lex->local_file && lex->duplicates == DUP_ERROR)
              lex->set_ignore(true);

So if load data with local keyword, the load will treat truncate error as warnings.

And tidb only support load data local infile, so should always ignore the error,
and tidb already handled this situation in executor/write.go:

func (e *LoadDataInfo) insertData(cols []string) {
	for i := 0; i < len(e.row); i++ {
		if i >= len(cols) {
			e.row[i].SetString("")
			continue
		}
		e.row[i].SetString(cols[i])
	}
	row, err := e.insertVal.fillRowData(e.columns, e.row, true)

The fillRowData's third parameter is true.

[shenli]

@zimulala PTAL

[hanfei1991]

LGTM

[zimulala]

If using the statement of load data infile behavior is like sql_mode is empty behavior, then we can directly set sql_mode value to empty when handling the statement of load data infile. Because the function considers the value of sql_mode.
And please add more tests to verify your claim.

[zimulala]

@louishust

[louishust]

@zimulala Ignore the sql_mode, only LOCAL keyword matters.

[zimulala]

I'm sorry, I forgot StrToInt implementation details.
You can consider it like the logical.@louishust

[louishust]

@zimulala modified the logic

[zimulala]

LGTM