Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typo and continue refactor variable name topn #3505

Merged
merged 2 commits into from
Jun 19, 2017
Merged

fix some typo and continue refactor variable name topn #3505

merged 2 commits into from
Jun 19, 2017

Conversation

unship
Copy link
Contributor

@unship unship commented Jun 19, 2017

@XuHuaiyu
Copy link
Contributor

LGTM

@XuHuaiyu XuHuaiyu added contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. labels Jun 19, 2017
hanfei1991
hanfei1991 approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli merged commit 4b4378f into pingcap:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unship @XuHuaiyu @hanfei1991 @shenli