Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: make Builder unexport #3496

Merged
merged 7 commits into from
Jun 19, 2017
Merged

ranger: make Builder unexport #3496

merged 7 commits into from
Jun 19, 2017

Conversation

winoros
Copy link
Member

@winoros winoros commented Jun 16, 2017

Accually Builder needn't be exported.
PTAL @shenli @hanfei1991 @coocood

// FullRange is (-∞, +∞).
var FullRange = []point{
// fullRangePoints is (-∞, +∞) and nil value.
var fullRangePoints = []point{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fullRange is clearer

@hanfei1991
Copy link
Member

LGTM

@winoros winoros added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 19, 2017
@winoros
Copy link
Member Author

winoros commented Jun 19, 2017

@shenli PTAL

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 19, 2017
@winoros winoros merged commit b6ca0dd into master Jun 19, 2017
@winoros winoros deleted the yiding/unexport branch June 19, 2017 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants