*: check visibility for show databases and tables #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Mar 27, 2017
executor/show.go
Outdated
| // sort for tables | ||
| var tableNames []string | ||
| for _, v := range e.is.SchemaTables(e.DBName) { | ||
| // TODO: Should consider column privileges, which also make a table visible. | ||
| if checker != nil && !checker.RequestVerification(e.DBName.O, v.Meta().Name.O, "", mysql.AllPriv-1) { |
There was a problem hiding this comment.
All privilege bits set to 1, means any kind of privileges would be OK.
coocood
reviewed
Mar 28, 2017
privilege/privileges/privileges.go
Outdated
| @@ -246,6 +246,31 @@ func (p *UserPrivileges) ConnectionVerification(user, host string, auth, salt [] | |||
| return true | |||
| } | |||
|
|
|||
| // ShowDatabase implements the Checker interface. | |||
| func (p *UserPrivileges) DBVisible(db string) bool { | |||
|
LGTM |
coocood
reviewed
Mar 28, 2017
privilege/privileges/cache.go
Outdated
| @@ -418,6 +418,43 @@ func (p *MySQLPrivilege) RequestVerification(user, host, db, table, column strin | |||
| return false | |||
| } | |||
|
|
|||
| // ShowDatabase checks whether the user can see the db. | |||
| func (p *MySQLPrivilege) ShowDatabase(user, host, db string) bool { | |||
|
LGTM |
coocood
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show databasesandshow tablesreturn just those visible to the user,if the user doesn't have privilege, he should not see it.