plan: add task profile. #2902
Merged
plan: add task profile. #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shenli @coocood @zimulala @tiancaiamao @XuHuaiyu @ilovesoup @lamxTyler @winoros |
hanfei1991
force-pushed
the
hanfei/profile
branch
from
17b6e1a to
140f6a0
Compare
|
This need a complete design document. |
|
@coocood I am agree with you. |
hanfei1991
force-pushed
the
hanfei/profile
branch
from
6f85e56 to
0945862
Compare
|
s/kvTask/copTask |
shenli
reviewed
Mar 27, 2017
plan/task_profile.go
Outdated
| import "github.com/pingcap/tidb/expression" | ||
|
|
||
| // taskProfile is a new version of `PhysicalPlanInfo`. It stores cost information for a task. | ||
| // A task may be KVTask, SingletonTask, MPPTask or a ParallelTask. |
plan/task_profile.go
Outdated
|
|
||
| // taskProfile is a new version of `PhysicalPlanInfo`. It stores cost information for a task. | ||
| // A task may be KVTask, SingletonTask, MPPTask or a ParallelTask. | ||
| type taskProfile interface { |
There was a problem hiding this comment.
Nope, toPB only required by kvTask.
shenli
reviewed
Mar 29, 2017
plan/task_profile.go
Outdated
| } | ||
| } | ||
|
|
||
| // rootTaskProfile is a profile running on tidb with single goroutine. |
There was a problem hiding this comment.
This description is better?
"rootTaskProfile is the final sink node of a plan graph. It should be a single goroutine on tidb."
plan/task_profile.go
Outdated
| type copTaskProfile struct { | ||
| indexPlan PhysicalPlan | ||
| tablePlan PhysicalPlan | ||
| cst float64 |
There was a problem hiding this comment.
Why not use cost? cst is rarely used.
There was a problem hiding this comment.
cost is used in function name
plan/task_profile.go
Outdated
| func (t *copTaskProfile) finishTask() { | ||
| t.cst += float64(t.cnt) * netWorkFactor | ||
| if t.tablePlan != nil && t.indexPlan != nil { | ||
| t.cst += float64(t.cnt) * netWorkFactor |
plan/task_profile.go
Outdated
| tablePlan PhysicalPlan | ||
| cst float64 | ||
| cnt uint64 | ||
| addPlan2Index bool |
plan/task_profile.go
Outdated
| return profile | ||
| } | ||
|
|
||
| func (sel *Selection) splitSelectionByIndexColumns(schema *expression.Schema) (indexSel *Selection, tableSel *Selection) { |
|
@shenli PTAL |
|
LGTM |
coocood
reviewed
Mar 31, 2017
plan/task_profile.go
Outdated
| // taskProfile is a new version of `PhysicalPlanInfo`. It stores cost information for a task. | ||
| // A task may be CopTask, RootTask, MPPTask or a ParallelTask. | ||
| type taskProfile interface { | ||
| attachPlan(p PhysicalPlan) taskProfile |
There was a problem hiding this comment.
Use a function instead of interface method is more intuitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to split the physical plan to computation tasks. This pr only define the structure for kvTask and singleton Task.