-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: donot prune all columns for Projection (#24024) #24093
planner: donot prune all columns for Projection (#24024) #24093
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@guo-shaoge you're already a collaborator in bot's repo. |
Signed-off-by: guo-shaoge <[email protected]>
@wshwsh12: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: guo-shaoge <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/run-all-tests |
Signed-off-by: guo-shaoge <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5100a75
|
/merge |
/run-integration-common-test |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-integration-tests |
… (pingcap#24093)" This reverts commit f5cac30. Signed-off-by: guo-shaoge <[email protected]>
cherry-pick #24024 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24093
After apply modifications, you can push your change to this PR via:
Signed-off-by: guo-shaoge [email protected]
What problem does this PR solve?
Issue Number: close #23887
Problem Summary:
Projection
col1
, Its index is 0(becauseProjection
's output columns are all pruned)Projection
is eliminated, because its output columns are all pruned. But Index Join still has output columnseq("abc", tbl1.col1)
. Because use index 0 to eval tbl1.col1What is changed and how it works?
What's Changed:
Projection
. IfProjection
is pruned to empty, we make it aProjection 1
(just like count(1))rule_eliminate_projection.go
, because Projection cannot be empty. Check hereRelated changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects: no
Release note