-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: ignore all other locks except the first one met by autocommit point select #24070
Conversation
287b913
to
8739c99
Compare
8739c99
to
b5c93c2
Compare
Signed-off-by: Yilin Chen <[email protected]>
b5c93c2
to
2881d0d
Compare
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2881d0d
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What is changed and how it works?
This PR reverts #22789. In addition, this PR makes point select with max ts ignore all locks except the first one.
The solution is to minimize changes done to the release-5.0 branch.
For the master branch, I think we can use a new protocol that brings the first lock's
start_ts
to reduce invalid retries.Check List
Tests
Benchmark result:
Release note
Fix performance regression of point select.