parser, evaluator: support mysql builtin functions ln(), log(), log2(), log10() #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
coocood
reviewed
Dec 15, 2016
| } | ||
|
|
||
| if x <= 0 { | ||
| d.SetNull() |
There was a problem hiding this comment.
d is null by default, we don't need to call SetNull, just return will do.
|
@hamo |
|
Good job! Please also add ln, log, log2, log10 to this table: Line 79 in 893a157 |
|
PTAL @tiancaiamao @coocood |
|
LGTM |
|
@hamo Thank your very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic support for mysql builtin functions ln(), log(), log2() and log10()
This change is