Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: 'INSERT IGNORE' should only ignore KeyExists error. #2241

Merged
merged 5 commits into from
Dec 13, 2016
Merged

executor: 'INSERT IGNORE' should only ignore KeyExists error. #2241

merged 5 commits into from
Dec 13, 2016

Conversation

disksing
Copy link
Contributor

When use 'INSERT IGNORE' to import data, all errors are ignored. It may cause data lost.

cc @coocood @shenli

@shenli
Copy link
Member

shenli commented Dec 13, 2016

LGTM

coocood
coocood reviewed Dec 13, 2016
View reviewed changes
kv/fault_injection.go
}

// InjectedSnapshot wraps a Snapshot with injections.
type InjectedSnapshot struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used.

@disksing
Copy link
Contributor Author

PTAL @coocood

@coocood
Copy link
Member

coocood commented Dec 13, 2016

LGTM

@disksing disksing merged commit 9c83f3f into master Dec 13, 2016
@disksing disksing deleted the disksing/ignore-err branch December 13, 2016 10:31
hanfei1991 pushed a commit that referenced this pull request Dec 14, 2016
@disksing @hanfei1991
executor: 'INSERT IGNORE' should only ignore KeyExists error. (#2241)
a502fd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disksing @shenli @coocood