util/types: provide time Format method #2206
Conversation
use Format to implement String(), so 00 month and day can be display
| package types | ||
|
|
||
| import ( | ||
| "fmt" |
| str, t.Expect)) | ||
| } | ||
|
|
||
| // error |
There was a problem hiding this comment.
there is already a TODO in the following line
| return ErrInvalidTimeFormat.Error() | ||
| } | ||
| return t1.Format(DateFormat) | ||
| // we'll control the format, so no error would occur. |
There was a problem hiding this comment.
If err is not nil, print a error log?
| // Get the final frac, with 6 digit number | ||
| // 0.1236 round 3 -> 124 -> 123000 | ||
| // 0.0312 round 2 -> 3 -> 30000 | ||
| return int(round * math.Pow10(MaxFsp-fsp)), nil | ||
| // 0.9999999 round 6 -> 1000000 -> overflow |
There was a problem hiding this comment.
move this comment above line 88?
There was a problem hiding this comment.
this would not be included in this PR, it not diff master, but diff
tiancaiamao/timestamp-no-zero from tiancaiamao/time-format
| fmt.Fprintf(buf, "%02d", t%12) | ||
| } | ||
| case 'l': | ||
| fmt.Fprintf(buf, "%d", (t.Time.Hour()%12)+1) |
| case 'f': | ||
| fmt.Fprintf(buf, "%06d", t.Time.Microsecond()) | ||
| case 'U', 'u', 'V', 'v': | ||
| // TODO: Fix here. |
There was a problem hiding this comment.
TODO: Fix here. is a special comment I use, so grep can find it easily.
mysql may use Sunday or Monday as the first day of week, U u V v controls which.
but Go always use Sunday as the first day of week, so not easy to do it now, I leave a TODO.
| if m == 0 || m > 12 { | ||
| return errors.Trace(ErrInvalidTimeFormat) | ||
| } | ||
| buf.WriteString(abbrevMonthName[m-1]) |
There was a problem hiding this comment.
Can it use MonthNames[m-1][:3]? Then no need abbrevMonthName.
| continue | ||
| } | ||
|
|
||
| // it's not in pattern match now |
Conflicts: util/types/fsp.go util/types/mytime.go util/types/time.go util/types/time_test.go
|
PTAL @hanfei1991 @zimulala |
tiancaiamao
changed the base branch from
tiancaiamao/timestamp-no-zero
to
master
|
LGTM |
| @@ -322,9 +321,14 @@ func (s *testTimeSuite) getLocation(c *C) *time.Location { | |||
|
|
|||
| func (s *testTimeSuite) TestCodec(c *C) { | |||
| defer testleak.AfterTest(c)() | |||
| t, err := ParseTimestamp("2010-10-10 10:11:11") | |||
| // mysql timestamp value don't allow month=0 or day=0. | |||
Conflicts: util/types/time_test.go
|
LGTM |
use Format to implement String(), so 00 month and day can be display
copy code mostly from evaluator builtinDateFormat, we can clean up them, later.
parseFracoverflow is irrelevant, and already in another PR, so it can be ignored when review.