util/types: refact Time introduce a TimeInternal interface #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go time representation is not compatible with mysql, this commit is a prepare before the code refact. timeInternal is a interface for time representation, and it would make the refact more smooth.
Conflicts: sessionctx/variable/session.go
tiancaiamao
changed the title
tiancaiamao
changed the title
This was referenced Nov 28, 2016
|
PTAL @coocood @hanfei1991 @zimulala |
zimulala
reviewed
Nov 29, 2016
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| loc := local | ||
| if t.Type == mysql.TypeTimestamp { | ||
| loc = time.UTC | ||
| } | ||
| t.Time = time.Date(year, time.Month(month), day, hour, minute, second, nanosec, loc).In(local) | ||
| t.Time = FromGoTime(time.Date(year, time.Month(month), day, hour, minute, second, microsec*1000, loc).In(local)) |
There was a problem hiding this comment.
Because we need convert UTC date to local date.
The whole argument is, notice the In()
time.Date(year, time.Month(month), day, hour, minute, second, microsec*1000, loc).In(local)
|
LGTM |
1 similar comment
|
LGTM |
tiancaiamao
force-pushed
the
tiancaiamao/time-internal
branch
from
5073d7f to
e1492c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go time representation is not compatible with mysql, this
commit is a prepare before the code refact.
TimeInternal is a interface for time representation, and it
would make the refact more smooth.