Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix error tikv_cop_wait time in metric profile #19859

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 [email protected]

What problem does this PR solve?

tikv_cop_wait metric has a type label, it has 3 values: all, schedule,snapshot. And the all total_time = schedule total time + snapshot total time.

METRICS_SCHEMA> select type,sum(value) from tikv_cop_wait_total_time group by type;
+----------+---------------------+
| type     | sum(value)          |
+----------+---------------------+
| all      | 6704.248505983651   |
| schedule | 6628.518727877801   |
| snapshot |   75.85378299487088 |
+----------+---------------------+

What is changed and how it works?

When collecting the total time of tikv_cop_wait, should ignore the all type value.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test

Before

image

This PR

image

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • Fix issue of tikv_cop_wait time in metric profile.

@crazycs520 crazycs520 requested a review from a team as a code owner September 8, 2020 03:49
@crazycs520 crazycs520 requested review from lzmhhh123 and removed request for a team September 8, 2020 03:49
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Sep 8, 2020
@crazycs520
Copy link
Contributor Author

/run-sqllogic-test-1

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-sqllogic-test-1

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 8, 2020
@crazycs520 crazycs520 merged commit 2d52e99 into pingcap:master Sep 8, 2020
@crazycs520 crazycs520 deleted the fix-cop-wait branch September 8, 2020 08:59
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 8, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants