-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix error tikv_cop_wait time in metric profile #19859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <[email protected]>
AilinKid
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-sqllogic-test-1 |
1 similar comment
/run-sqllogic-test-1 |
wjhuang2016
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Sep 8, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 8, 2020
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #19881 |
bb7133
pushed a commit
that referenced
this pull request
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
tikv_cop_wait
metric has atype
label, it has 3 values:all
,schedule
,snapshot
. And theall total_time
=schedule total time
+snapshot total time
.What is changed and how it works?
When collecting the total time of
tikv_cop_wait
, should ignore theall
type value.Related changes
Check List
Tests
Before
This PR
Side effects
Release note