Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix file exists errors in tests for select into outfile (#19717) #19725

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19717 to release-4.0


What problem does this PR solve?

Issue Number: close #19718

Problem Summary: executor: fix file exists errors in tests for select into outfile

What is changed and how it works?

Use random file names to avoid file name conflict.

Check List

Tests

  • Unit test

Release note

  • executor: fix file exists errors in tests for select into outfile

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Sep 3, 2020

/run-all-tests

@qw4990 qw4990 force-pushed the release-4.0-0fd81a83e8a0 branch from 97cbfec to 77abc15 Compare September 3, 2020 03:35
@qw4990
Copy link
Contributor

qw4990 commented Sep 3, 2020

Wait for #19672

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 3, 2020
@winoros winoros merged commit 06fbed8 into pingcap:release-4.0 Sep 3, 2020
@winoros winoros deleted the release-4.0-0fd81a83e8a0 branch September 3, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants