expression: avoid unnecessary warnings/errors when folding constants in control expr #19675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhedu
requested review from
qw4990 and
eurekaka
and removed request for
a team
|
/run-check_dev_2 |
|
/run-check_dev_2 |
1 similar comment
|
/run-check_dev_2 |
fzhedu
force-pushed
the
FoldControlExpr
branch
from
4e4b6d3 to
64fc856
Compare
zz-jason
reviewed
Sep 3, 2020
fzhedu
force-pushed
the
FoldControlExpr
branch
from
64fc856 to
9c3f2f5
Compare
qw4990
reviewed
Sep 8, 2020
ti-srebot
approved these changes
Sep 8, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@fzhedu merge failed. |
ti-srebot
added
status/LGT3
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 9, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #19910 |
ti-srebot
added a commit
that referenced
this pull request
Sep 16, 2020
…in control expr (#19675) (#19910) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17725
following #19367, avoid unnecessary warnings/errors when folding constants in control expr.
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
the scalar
ifis wrong, to be corrected here,add
tryFoldCounterto try fold constrants but not throw warnings/erros.correct the special handler for control expressions.
How it Works:
each branch of control expressions fold contrants whenever possible, but not throw uncessary warnings/errors. When folding the control expressions, it run the normal branches and return normally like evaluating scalar expressions. If a branch is not const, it will stop folding constrants.
Related changes
Check List
Tests
Release note