-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix issue pre_split_regions
table option doesn't work in the partition table. (#18144)
#18837
Merged
SunRunAway
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-33f4b82166ad
Jul 29, 2020
Merged
ddl: fix issue pre_split_regions
table option doesn't work in the partition table. (#18144)
#18837
SunRunAway
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-33f4b82166ad
Jul 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
ti-srebot
added
sig/sql-infra
SIG: SQL Infra
sig/execution
SIG execution
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Jul 28, 2020
Signed-off-by: crazycs520 <[email protected]>
wjhuang2016
reviewed
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AilinKid
reviewed
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jul 29, 2020
/run-all-tests |
AilinKid
approved these changes
Jul 29, 2020
/run-integration-copr-test |
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18144 to release-4.0
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
Close #14478
When create partition table, the
pre_split_regions
table option doesn't work.After create table, before this PR, TiDB only split 1 regino for the separate partition:
In this PR, every partition of the table will have 4 regions.
What is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note
pre_split_regions
table option doesn't work in the partition table.