Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix create hash partition table makes tidb OOM #16194

Merged
merged 2 commits into from
Apr 9, 2020
Merged

ddl: fix create hash partition table makes tidb OOM #16194

merged 2 commits into from
Apr 9, 2020

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

CREATE TABLE employees (
    id INT NOT NULL,
    fname VARCHAR(30),
    lname VARCHAR(30),
    hired DATE NOT NULL DEFAULT '1970-01-01',
    separated DATE NOT NULL DEFAULT '9999-12-31',
    job_code INT,
    store_id INT
)

PARTITION BY HASH(store_id)
PARTITIONS 102400000000;

TiDB OOM

What is changed and how it works?

Check the partition count before create the slice.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

@tiancaiamao tiancaiamao added type/bugfix This PR fixes a bug. sig/sql-infra SIG: SQL Infra labels Apr 8, 2020
@tiancaiamao
Copy link
Contributor Author

PTAL @crazycs520 @jackysp @lysu

@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #16194 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16194   +/-   ##
===========================================
  Coverage   80.5440%   80.5440%           
===========================================
  Files           505        505           
  Lines        135917     135917           
===========================================
  Hits         109473     109473           
  Misses        17940      17940           
  Partials       8504       8504

crazycs520
crazycs520 reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackysp
jackysp approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

Your auto merge job has been accepted, waiting for 16198

@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

@tiancaiamao merge failed.

@jackysp
Copy link
Member

jackysp commented Apr 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

Your auto merge job has been accepted, waiting for 16139, 15761

@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 4a803b1 into pingcap:master Apr 9, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020
@tiancaiamao @sre-bot
cherry pick pingcap#16194 to release-3.0
53aa99a 
Signed-off-by: sre-bot <[email protected]>
@sre-bot sre-bot mentioned this pull request Apr 9, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-3.0 in PR #16218

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020
@tiancaiamao @sre-bot
ddl: fix create hash partition table makes tidb OOM (pingcap#16194)
2de5533
@sre-bot sre-bot mentioned this pull request Apr 9, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-3.1 in PR #16219

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020
@tiancaiamao @sre-bot
ddl: fix create hash partition table makes tidb OOM (pingcap#16194)
4ba14d8
@sre-bot sre-bot mentioned this pull request Apr 9, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-4.0 in PR #16220

sre-bot added a commit that referenced this pull request Apr 9, 2020
@sre-bot
ddl: fix create hash partition table makes tidb OOM (#16194) (#16219)
b210564
sre-bot added a commit that referenced this pull request Apr 14, 2020
@sre-bot
ddl: fix create hash partition table makes tidb OOM (#16194) (#16218)
e729528
zz-jason pushed a commit that referenced this pull request Apr 23, 2020
@sre-bot
ddl: fix create hash partition table makes tidb OOM (#16194) (#16220)
e36d116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @jackysp @sre-bot @crazycs520