server: fix SIGSEGV caused by port probing with audit plugin (#16038) #16065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/plugin
component/server
status/PTAL
type/3.1-cherry-pick
type/bugfix
|
@lysu please fix conflict |
lysu
force-pushed
the
release-3.1-6d02bc72d9c0
branch
from
5e7e12d to
036fb24
Compare
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16038 to release-3.1
What problem does this PR solve?
Issue Number: close #16037
Problem Summary:
port probing will establish tcp connection, then exit without send any auth packet, so conn's session ctx should be nil and this cause crash in audit plugin code path.
What is changed and how it works?
What's Changed:
ensure session ctx is not nil before do reject audit.
How it Works:
check nil
Related changes
Check List
Tests
Side effects
Release note
This change is