planner: fix panic of merge join for tables with redundant indexes (#15840) #15921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/planner
ghost
requested a review
from 
|
/run-all-tests |
eurekaka
requested review from
lzmhhh123
and removed request for
winoros and
XuHuaiyu
|
/run-unit-test |
|
/run-all-tests |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15840 to release-4.0
What problem does this PR solve?
Issue Number: close #15813
Problem Summary:
MergeJoin for tables with redundant index would panic.
What is changed and how it works?
Proposal: xxx
What's Changed:
Use length of de-duplicated conditions instead of original length for declaring slice in
moveEqualToOtherConditions.How it Works:
Avoid the capacity of slice to be out of bound.
Related changes
Check List
Tests
Side effects
N/A
Release note