Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix the 'Unknown column' error when select from view in another database (#15621) #15867

Merged
merged 4 commits into from
Apr 4, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 30, 2020

cherry-pick #15621 to release-3.1


What problem does this PR solve?

fix #15611

Issue Number: close #15611

What is changed and how it works?

What's Changed:

Changing this line to DBName: dbName

Just as @XuHuaiyu mentioned.

Related changes

NA

Release note

NA

Unit test is already added.

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 30, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuHuaiyu Could you help to solve the conflict?

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 2, 2020

Your auto merge job has been accepted, waiting for 15894

@zz-jason zz-jason removed the request for review from XuHuaiyu April 2, 2020 06:23
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 2, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 2, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit e00c1f8 into pingcap:release-3.1 Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants