planner, executor: adjustOverlongColName for CreateView (#14850) #14873

XuHuaiyu · 2020-02-20T10:15:54Z

cherry-pick #14850

What problem does this PR solve?

Fix the bug:

On TiDB:
mysql root@127.0.0.1:test> create view v0 as select 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
(1059, "Identifier name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' is too long")

On MySQL:
mysql root@127.0.0.1:test> create view v0 as select 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
Query OK, 0 rows affected
Time: 0.008s
mysql root@127.0.0.1:test> select * from v0
+-------------------------------------------------------------------+
| Name_exp_1 |
+-------------------------------------------------------------------+
| aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa |
+-------------------------------------------------------------------+
1 row in set
Time: 0.015s

What is changed and how it works?

Rename the output column name for view if the column name is too long (>64).

Check List

Tests

Integration test

Code changes

Has exported function/method change

Side effects

There are still some compatible problems exist. But I think the behavior of TiDB is more reasonable than MySQL, and there is no official MySQL manual taking about this behavior.

case 1:
In MySQL, use the sql shown in the result of show create view to create a view will fail. It is really strange. In TiDB, this case will fail for the first time.

mysql> create view v(`aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`) as select a from t; -- TiDB will fail here.
Query OK, 0 rows affected (0.01 sec)

mysql> show create view v;
+------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+
| View | Create View                                                                                                                                                                                                                                                    | character_set_client | collation_connection |
+------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+
| v    | CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v` AS select `t`.`a` AS `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` from `t` | utf8                 | utf8_general_ci      |
+------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+
1 row in set (0.00 sec)

mysql> drop view v;
Query OK, 0 rows affected (0.00 sec)

mysql> CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v` AS select `t`.`a` AS `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` from `t`;
ERROR 1166 (42000): Incorrect column name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'

case 2:

In MySQL, the following case will fail. But it will execute successfully in TiDB.

create view v as select 'a' as 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' from t;

Related changes

Need to cherry-pick to the release branch

Release note

Adjust the colName to name_exp_$off if a column name is overlong when creating the view.

crazycs520

LGTM

qw4990

LGTM

sre-bot · 2020-02-21T08:26:40Z

/run-all-tests

sre-bot · 2020-02-21T08:33:11Z

@XuHuaiyu merge failed.

winoros · 2020-03-05T12:02:41Z

@XuHuaiyu PTAL

zz-jason · 2020-03-14T07:41:31Z

/merge

sre-bot · 2020-03-14T07:41:34Z

Your auto merge job has been accepted, waiting for 15365, 14939

sre-bot · 2020-03-14T10:53:00Z

/run-all-tests

sre-bot · 2020-03-14T10:58:53Z

@XuHuaiyu merge failed.

zz-jason · 2020-03-14T11:26:41Z

a data race detected in etcd:

[2020-03-14T10:53:48.150Z] ==================
[2020-03-14T10:53:48.150Z] WARNING: DATA RACE
[2020-03-14T10:53:48.151Z] Write at 0x00c000d66888 by goroutine 139:
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*keyIndex).put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/key_index.go:101 +0x1f6
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*treeIndex).Put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/index.go:65 +0x1db
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*storeTxnWrite).put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/kvstore_txn.go:211 +0x40e
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*storeTxnWrite).Put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/kvstore_txn.go:97 +0x8b
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*metricsTxnWrite).Put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/metrics_txn.go:46 +0xeb
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*watchableStoreTxnWrite).Put()
[2020-03-14T10:53:48.151Z]       <autogenerated>:1 +0xbb
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*applierV3backend).Put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/apply.go:217 +0x36c
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*quotaApplierV3).Put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/apply.go:829 +0xc2
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*authApplierV3).Put()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/apply_auth.go:83 +0x1b5
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*applierV3backend).Apply()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/apply.go:124 +0x38d
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*quotaApplierV3).Apply()
[2020-03-14T10:53:48.151Z]       <autogenerated>:1 +0x68
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*authApplierV3).Apply()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/apply_auth.go:58 +0x111
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).applyEntryNormal()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/server.go:2011 +0x5d8
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).apply()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/server.go:1925 +0x792
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).applyEntries()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/server.go:1349 +0x177
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).applyAll()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/server.go:1075 +0x98
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).run.func8()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/server.go:1020 +0x53
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/pkg/schedule.(*fifo).run()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/pkg/schedule/schedule.go:157 +0x11b
[2020-03-14T10:53:48.151Z]
[2020-03-14T10:53:48.151Z] Previous read at 0x00c000d66888 by goroutine 22:
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*keyIndex).get()
[2020-03-14T10:53:48.151Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/key_index.go:365 +0x684
[2020-03-14T10:53:48.151Z]   go.etcd.io/etcd/mvcc.(*treeIndex).Revisions.func1()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/index.go:116 +0xab
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*treeIndex).visit.func1()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/index.go:102 +0x8b
[2020-03-14T10:53:48.152Z]   github.com/google/btree.(*node).iterate()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/google/[email protected]/btree.go:524 +0x85e
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*treeIndex).visit()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/google/[email protected]/btree.go:768 +0x40f
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*treeIndex).Revisions()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/index.go:115 +0x20d
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*storeTxnRead).rangeKeys()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/kvstore_txn.go:128 +0x377
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*storeTxnRead).Range()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/kvstore_txn.go:50 +0xe4
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*txnReadWrite).Range()
[2020-03-14T10:53:48.152Z]       <autogenerated>:1 +0xf4
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/mvcc.(*metricsTxnWrite).Range()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/mvcc/metrics_txn.go:36 +0x12a
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver.(*applierV3backend).Range()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/apply.go:275 +0x325
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).Range.func3()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/v3_server.go:104 +0x9d
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).doSerialize()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/v3_server.go:554 +0xad
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).Range()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/v3_server.go:105 +0x1f5
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver/api/v3rpc.(*kvServer).Range()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/api/v3rpc/key.go:52 +0xb0
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver/api/v3rpc.(*quotaKVServer).Range()
[2020-03-14T10:53:48.152Z]       <autogenerated>:1 +0x87
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver/etcdserverpb._KV_Range_Handler.func1()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/etcdserverpb/rpc.pb.go:3473 +0xa1
[2020-03-14T10:53:48.152Z]   github.com/grpc-ecosystem/go-grpc-middleware.ChainUnaryServer.func1.1()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/chain.go:31 +0x2d3
[2020-03-14T10:53:48.152Z]   github.com/grpc-ecosystem/go-grpc-prometheus.(*ServerMetrics).UnaryServerInterceptor.func1()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/server_metrics.go:107 +0xff
[2020-03-14T10:53:48.152Z]   github.com/grpc-ecosystem/go-grpc-middleware.ChainUnaryServer.func1.1()
[2020-03-14T10:53:48.152Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/chain.go:34 +0x1d9
[2020-03-14T10:53:48.152Z]   go.etcd.io/etcd/etcdserver/api/v3rpc.newUnaryInterceptor.func1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/api/v3rpc/interceptor.go:60 +0x10c
[2020-03-14T10:53:48.153Z]   github.com/grpc-ecosystem/go-grpc-middleware.ChainUnaryServer.func1.1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/chain.go:34 +0x1d9
[2020-03-14T10:53:48.153Z]   go.etcd.io/etcd/etcdserver/api/v3rpc.newLogUnaryInterceptor.func1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/api/v3rpc/interceptor.go:67 +0xda
[2020-03-14T10:53:48.153Z]   github.com/grpc-ecosystem/go-grpc-middleware.ChainUnaryServer.func1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/chain.go:39 +0x33f
[2020-03-14T10:53:48.153Z]   go.etcd.io/etcd/etcdserver/etcdserverpb._KV_Range_Handler()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/etcdserverpb/rpc.pb.go:3475 +0x1d8
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc.(*Server).processUnaryRPC()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/server.go:966 +0x92f
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc.(*Server).handleStream()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/server.go:1245 +0x132b
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc.(*Server).serveStreams.func1.1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/server.go:685 +0xc8
[2020-03-14T10:53:48.153Z]
[2020-03-14T10:53:48.153Z] Goroutine 139 (running) created at:
[2020-03-14T10:53:48.153Z]   go.etcd.io/etcd/pkg/schedule.NewFIFOScheduler()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/pkg/schedule/schedule.go:70 +0x2b1
[2020-03-14T10:53:48.153Z]   go.etcd.io/etcd/etcdserver.(*EtcdServer).run()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/go.etcd.io/[email protected]/etcdserver/server.go:905 +0x327
[2020-03-14T10:53:48.153Z]
[2020-03-14T10:53:48.153Z] Goroutine 22 (finished) created at:
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc.(*Server).serveStreams.func1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/server.go:683 +0xb8
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/internal/transport/http2_server.go:419 +0x14e2
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/internal/transport/http2_server.go:459 +0x39f
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc.(*Server).serveStreams()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/server.go:681 +0x19a
[2020-03-14T10:53:48.153Z]   google.golang.org/grpc.(*Server).handleRawConn.func1()
[2020-03-14T10:53:48.153Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/google.golang.org/[email protected]/server.go:643 +0x50
[2020-03-14T10:53:48.153Z] ==================

planner, executor: adjustOverlongColName for CreateView (pingcap#14850)

2d8e10b

XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.0 cherry-pick labels Feb 20, 2020

XuHuaiyu requested review from qw4990 and crazycs520 February 20, 2020 10:15

fix ci

e514dbd

crazycs520 reviewed Feb 20, 2020

View reviewed changes

qw4990 approved these changes Feb 20, 2020

View reviewed changes

SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2020

XuHuaiyu mentioned this pull request Feb 21, 2020

planner, executor: adjustOverlongColName for CreateView #14850

Merged

github-actions bot added the sig/execution SIG execution label Mar 8, 2020

zz-jason added type/3.0 cherry-pick and removed type/3.0-cherry-pick labels Mar 11, 2020

Merge branch 'release-3.0' into release-3.0

2fa7e4e

Merge branch 'release-3.0' into release-3.0

34edc94

zz-jason merged commit 3400fe5 into pingcap:release-3.0 Mar 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner, executor: adjustOverlongColName for CreateView (#14850) #14873

planner, executor: adjustOverlongColName for CreateView (#14850) #14873

XuHuaiyu commented Feb 20, 2020

crazycs520 left a comment

qw4990 left a comment

sre-bot commented Feb 21, 2020

sre-bot commented Feb 21, 2020

winoros commented Mar 5, 2020

zz-jason commented Mar 14, 2020

sre-bot commented Mar 14, 2020

sre-bot commented Mar 14, 2020

sre-bot commented Mar 14, 2020

zz-jason commented Mar 14, 2020 •

edited

Loading

planner, executor: adjustOverlongColName for CreateView (#14850) #14873

planner, executor: adjustOverlongColName for CreateView (#14850) #14873

Conversation

XuHuaiyu commented Feb 20, 2020

What problem does this PR solve?

What is changed and how it works?

Check List

crazycs520 left a comment

Choose a reason for hiding this comment

qw4990 left a comment

Choose a reason for hiding this comment

sre-bot commented Feb 21, 2020

sre-bot commented Feb 21, 2020

winoros commented Mar 5, 2020

zz-jason commented Mar 14, 2020

sre-bot commented Mar 14, 2020

sre-bot commented Mar 14, 2020

sre-bot commented Mar 14, 2020

zz-jason commented Mar 14, 2020 • edited Loading

zz-jason commented Mar 14, 2020 •

edited

Loading