Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: change the query start time to the parsing time (#11159) #12638

Merged
merged 1 commit into from
Oct 12, 2019
Merged

*: change the query start time to the parsing time (#11159) #12638

merged 1 commit into from
Oct 12, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #11159 to release-2.1

# Conflicts:
#       executor/adapter.go
#       executor/prepared.go
#       session/session.go
#       sessionctx/stmtctx/stmtctx.go
#       sessionctx/variable/session.go
#       sessionctx/variable/session_test.go

original pr description:

What problem does this PR solve?

At present, the query start time is the time when it begins to execute. Haven't counted the query parse and compile time.

What is changed and how it works?

As the PR title says, changing the query start time to the parsing time.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution type/2.1 cherry-pick labels Oct 12, 2019
@zz-jason zz-jason requested review from jackysp and lysu October 12, 2019 03:15
jackysp
jackysp reviewed Oct 12, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2019
lysu
lysu approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2019
@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit fb9f4a2 into pingcap:release-2.1 Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zz-jason @sre-bot @lysu @jackysp