*: wrap the previous statement for performance #12283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <[email protected]>
|
/bench |
Signed-off-by: Shuaipeng Yu <[email protected]>
@@ Benchmark Diff @@
================================================================================
--- tidb: f9724dbf3bcb9fc58d0d854391c0ba9f87c3fbd4
+++ tidb: a5c26bb56a590fa78aea6999edfbf88693c21c5d
tikv: f2bb322e6fffd72c26f0ef268f99e0d8441389aa
pd: 4ca2265d180531191dcfc531e468ab8380737a33
================================================================================
test-1: < oltp_read_write >
* QPS : 37202.67 ± 0.2127% (std=54.65) delta: 0.63%
* AvgMs : 138.17 ± 0.2334% (std=0.22) delta: -0.61%
* PercentileMs99 : 267.41 ± 0.0000% (std=0.00) delta: 0.00%
test-2: < oltp_point_select >
* QPS : 81827.59 ± 1.2476% (std=707.11) delta: 0.95%
* AvgMs : 3.13 ± 1.2780% (std=0.03) delta: -0.84%
* PercentileMs99 : 6.65 ± 2.1667% (std=0.09) delta: 0.36%
test-3: < oltp_insert >
* QPS : 21895.46 ± 0.1378% (std=23.21) delta: 0.16%
* AvgMs : 11.68 ± 0.1427% (std=0.01) delta: -0.19%
* PercentileMs99 : 23.95 ± 0.0000% (std=0.00) delta: 0.00%
test-4: < oltp_update_index >
* QPS : 17145.03 ± 0.2801% (std=32.67) delta: 0.33%
* AvgMs : 14.86 ± 0.5517% (std=0.07) delta: -0.09%
* PercentileMs99 : 30.48 ± 1.0827% (std=0.27) delta: -0.36%
test-5: < oltp_update_non_index >
* QPS : 29141.14 ± 0.2300% (std=46.86) delta: 0.32%
* AvgMs : 8.78 ± 0.2278% (std=0.01) delta: -0.23%
* PercentileMs99 : 18.61 ± 0.0000% (std=0.00) delta: 0.00%
|
lonng
reviewed
Sep 19, 2019
|
PTAL @lonng |
lonng
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12283 +/- ##
===========================================
Coverage 81.2741% 81.2741%
===========================================
Files 454 454
Lines 100049 100049
===========================================
Hits 81314 81314
Misses 12928 12928
Partials 5807 5807 |
|
Wide table batch insert case: |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Sep 24, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Oct 16, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 16, 2019
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Nov 7, 2019
…ap#12325) Conflicts: sessionctx/variable/session.go
sre-bot
pushed a commit
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu [email protected]
What problem does this PR solve?
Formating a long previous statement takes too many resources, which may hurt the performance.
What is changed and how it works?
Warp it to a
fmt.Stringer.Check List
Tests
Code changes
Related changes