Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in ConvertJSONToInt error msg (#11493) #11562

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

H-ZeX
Copy link
Contributor

@H-ZeX H-ZeX commented Aug 1, 2019

cherry-pick #11493 to release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from SunRunAway and qw4990 August 3, 2019 08:29
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2019
@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5ecbc61 into pingcap:release-2.1 Aug 5, 2019
@H-ZeX H-ZeX deleted the release-2.1 branch August 12, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants